From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC v5 12/86] memory: add ioeventfd support Date: Fri, 22 Jul 2011 10:05:17 +0300 Message-ID: <4E29212D.6020209@redhat.com> References: <1311180636-17012-1-git-send-email-avi@redhat.com> <1311180636-17012-13-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Blue Swirl Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 07/21/2011 10:55 PM, Blue Swirl wrote: > On Wed, Jul 20, 2011 at 7:49 PM, Avi Kivity wrote: > > As with the rest of the memory API, the caller associates an eventfd > > with an address, and the memory API takes care of registering or > > unregistering when the address is made visible or invisible to the > > guest. > > > > + > > +static bool memory_region_ioeventfd_before(MemoryRegionIoeventfd a, > > + MemoryRegionIoeventfd b) > > +{ > > + if (a.addr.start< b.addr.start) return true; > > + if (a.addr.start> b.addr.start) return false; > > + if (a.addr.size< b.addr.size) return true; > > + if (a.addr.size> b.addr.size) return false; > > + if (a.match_data< b.match_data) return true; > > + if (a.match_data> b.match_data) return false; > > + if (a.match_data) { > > + if (a.data< b.data) return true; > > + if (a.data> b.data) return false; > > + } > > + if (a.fd< b.fd) return true; > > + if (a.fd> b.fd) return false; > > NACK for CO.. Wait, is this another trap? This is already fixed in my tree; v5 was already posted when you made your review (or at least, when I read it). -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.