Re: [PATCH] cpu hotplug issue

Gleb Natapov
2011-07-21T13:11:10Z

On Thu, Jul 21, 2011 at 03:08:37PM +0200, Vasilis Liaskovitis wrote:
> Hi,
>
> thanks for looking at this closer.
>
> On Thu, Jul 21, 2011 at 1:33 PM, Gleb Natapov <gleb@redhat.com> wrote:
>
> >> Note that there is probably another bug in qemu-kvm/master regarding
> >> acpi-udev event delivery for
> >> a cpu-hotplug event (cpu_set in the qemu_monitor no longer triggers
> >> the event in the guest, see
> >> first issue in my original mail). This patch does not address that issue.
> >>
> > Did this work in qemu-0.13?
>
> yes, the acpi-event delivery worked fine for me in 0.13.0
>
I've already sent a patch to fix this problem in one of the emails in this thread.

> I also tried to separately bisect the acpi-udev delivery issue between
> 0.13.0 and qemu-kvm/master but ended up
> with a big merge commit as the culprit. Not sure if it would help.
>
> FWIW, here's my "git bisect log" for the acpi-udev delivery issue:
>
> git bisect start
> # good: [2e1e73f3d746feffc1c12e9463b2fc04e10df860] Merge remote branch
> 'upstream/stable-0.13' into stable-0.13
> git bisect good 2e1e73f3d746feffc1c12e9463b2fc04e10df860
> # bad: [fda19064e889d4419dd3dc69ca8e6e7a1535fdf5] Merge branch 'upstream-merge'
> git bisect bad fda19064e889d4419dd3dc69ca8e6e7a1535fdf5
> # good: [01ac6428a04576ae6f84f07d82c98da304b9ac77] Fix memory leak in
> register save load due to xsave support
> git bisect good 01ac6428a04576ae6f84f07d82c98da304b9ac77
> # good: [f14224a695f51576e33d96a4bc26b9a67899dbb9] kvm_stat: add 'x'
> key for enabling/disabling "drilldown"
> git bisect good f14224a695f51576e33d96a4bc26b9a67899dbb9
> # good: [f14224a695f51576e33d96a4bc26b9a67899dbb9] kvm_stat: add 'x'
> key for enabling/disabling "drilldown"
> git bisect good f14224a695f51576e33d96a4bc26b9a67899dbb9
> # bad: [f47b14bbbe43fbaef9137e2abea8d300a6e6287f] Merge commit
> '45fe15c25a5c9feea6e0f78434f5e9f632de9d94' into upstream-merge
> git bisect bad f47b14bbbe43fbaef9137e2abea8d300a6e6287f
> # good: [d23948b15a9920fb7f6374b55a6db1ecff81f3ee] lm32: add Milkymist
> VGAFB support
> git bisect good d23948b15a9920fb7f6374b55a6db1ecff81f3ee
> # good: [47c0143cdde080101e97a1b39f3ff13e33b5726c] target-i386: add
> CPU86_LDouble <-> double conversion functions
> git bisect good 47c0143cdde080101e97a1b39f3ff13e33b5726c
> # good: [d2d979c628e4b2c4a3cb71a31841875795c79043] NBD: Avoid leaking
> a couple of strings when the NBD device is closed
> git bisect good d2d979c628e4b2c4a3cb71a31841875795c79043
> # bad: [70757dcaa40e14978bf287084d8fab9efb815a2d] qemu-kvm: Limit MSI
> vector walk to actual array size
> git bisect bad 70757dcaa40e14978bf287084d8fab9efb815a2d
> # good: [913f5649dc778a1635e3440edba3429d84caec89] Merge commit
> 'a9f8ad8f2acdb2398da5d32a5efc19cb0196d79f' into upstream-merge
> git bisect good 913f5649dc778a1635e3440edba3429d84caec89
> # bad: [ad16018ee64433754914b73782da94fe2bcc0dac] qemu-kvm: Move gsi
> bits from kvm_msix_vector_add to kvm_msi_add_message
> git bisect bad ad16018ee64433754914b73782da94fe2bcc0dac
> # bad: [98e934f0ab47583e82e3cabaa1c6a48c816e7bd0] qemu-kvm:
> Synchronize states before reset
> git bisect bad 98e934f0ab47583e82e3cabaa1c6a48c816e7bd0
> # bad: [dc080800baef853f5a4d383d4f00d6afa7a46ff4] Merge branch 'upstream-merge'
> git bisect bad dc080800baef853f5a4d383d4f00d6afa7a46ff4
> # bad: [7d821420734b3e1fed438ae41b5791eb281f9448] Merge commit
> '4d9ad7f793605abd9806fc932b3e04e028894565' into upstream-merge
> git bisect bad 7d821420734b3e1fed438ae41b5791eb281f9448
> # bad: [fc58948644fe3975c541f8452c63dd2d257587bd] Merge commit
> '23910d3f669d46073b403876e30a7314599633af' into upstream-merge
> git bisect bad fc58948644fe3975c541f8452c63dd2d257587bd
>
> fc58948644fe3975c541f8452c63dd2d257587bd is the first bad commit
>
> git show fc58948644fe3975c541f8452c63dd2d257587bd
>
> commit fc58948644fe3975c541f8452c63dd2d257587bd
> Merge: 913f564 23910d3
> Author: Marcelo Tosatti <mtosatti@redhat.com>
> Date: Fri Apr 15 08:35:38 2011 -0300
>
> Merge commit '23910d3f669d46073b403876e30a7314599633af' into upstream-merge
>
> * commit '23910d3f669d46073b403876e30a7314599633af': (109 commits)
> acpi, acpi_piix: factor out GPE logic
> arm: basic support for ARMv4/ARMv4T emulation
> Fix conversions from pointer to tcg_target_long
> vnc: tight: Fix crash after 2GB of output
> smbus_eeprom: consolidate smbus eeprom creation oc pc_piix,
> mips_mapta, mips_fulong
> lan9118: Ignore write to MAC_VLAN1 register
> acpi, acpi_piix, vt82c686: factor out PM1_CNT logic
> acpi, acpi_piix, vt82c686: factor out PM1a EVT logic
> acpi, acpi_piix, vt82c686: factor out PM_TMR logic
> hw/pflash_cfi02: Fix lazy reset of ROMD mode
> configure: avoid basename usage message
> mpc85xx_pci_map_irq: change "unknow" to "unknown"
> event: trivial coding style fixes
> multiboot: Quote filename in error message
> ppce500_mpc8544ds: Fix compile with --enable-debug and --disable-kvm
> Use existing helper function to implement popcntd instruction
> Delay creation of pseries device tree until reset
> pseries: Abolish envs array
> spapr_vscsi: Set uninitialized variable
> Don't call cpu_synchronize_state() from machine init.
> ...
>
> Conflicts:
> hw/acpi_piix4.c
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> diff --cc Makefile.objs
> index 1fc3708,44ce368..895d416
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@@ -14,10 -14,9 +14,10 @@@ oslib-obj-$(CONFIG_POSIX) += oslib-posi
> # block-obj-y is code used by both qemu system emulation and qemu-img
>
> block-obj-y = cutils.o cache-utils.o qemu-malloc.o qemu-option.o
> module.o async.o
> - block-obj-y += nbd.o block.o aio.o aes.o qemu-config.o
> + block-obj-y += nbd.o block.o aio.o aes.o qemu-config.o
> qemu-progress.o qemu-sockets.o
> block-obj-$(CONFIG_POSIX) += posix-aio-compat.o
> block-obj-$(CONFIG_LINUX_AIO) += linux-aio.o
> +block-obj-$(CONFIG_POSIX) += compatfd.o
>
> block-nested-y += raw.o cow.o qcow.o vdi.o vmdk.o cloop.o dmg.o
> bochs.o vpc.o vvfat.o
> block-nested-y += qcow2.o qcow2-refcount.o qcow2-cluster.o
> qcow2-snapshot.o qcow2-cache.o
> diff --cc Makefile.target
> index 3e70627,d5761b7..3a37205
> --- a/Makefile.target
>
>
>
> - Vasilis

--
Gleb.