Re: [PATCH] cpu hotplug issue

Lucas Meneghel Rodrigues
2011-07-21T13:27:48Z

On 07/21/2011 09:18 AM, Avi Kivity wrote:
> On 07/21/2011 02:55 PM, Jan Kiszka wrote:
>> >>
>> > CPU hotplug for Linux suppose to be easy (with allow_hotplug patch
>> > applied). But we have two bugs currently. One is that ACPI interrupt
>>
>> I bet we have multiple bugs for quite a while now, which accelerated bit
>> rotting even further.
>>
>
> kvm-autotest to the rescue!
>
> Lucas, do we have a cpu hotplug test in kvm-autotest?

Hey Avi, I just read the thread, and let me tell you guys, I have worked
on a cpu_set test, that was supposed to test CPU hotplug. I have created
the entire test, however, I could never ever get the test to pass due to
the fact that the infrastructure on qemu is broken. I have revisited the
test late 2010, and I've verified that although cpu_set does not crash
qemu anymore, the guest OS has no idea whatsoever that a new CPU was
added. I remember that one of the problems we had was lack of
functionality in Seabios...

I can gladly get back to it and get it commited (I was reluctant in
getting it upstream because I never ever got a successful test result),
but I can put it into shape and get it commited.

Cheers,

Lucas

> If so, I promise to add it to my autotest run once it is fixed, to
> prevent the spread of the disease.
>
> btw, Anthony, are you running kvm-autotest these days? with qemu-kvm
> diverging less and less from qemu.git these days, it's becoming less
> effective to run it downstream.
>