From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW() Date: Mon, 25 Jul 2011 09:25:27 -0500 Message-ID: <4E2D7CD7.1060707@codemonkey.ws> References: <1311583872-362-1-git-send-email-avi@redhat.com> <4E2D5D7C.40208@codemonkey.ws> <4E2D5F0D.2040303@redhat.com> <4E2D5FB3.7000906@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Avi Kivity , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Blue Swirl Return-path: Received: from mail-yw0-f46.google.com ([209.85.213.46]:39566 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752133Ab1GYOZa (ORCPT ); Mon, 25 Jul 2011 10:25:30 -0400 Received: by ywe9 with SMTP id 9so2248678ywe.19 for ; Mon, 25 Jul 2011 07:25:29 -0700 (PDT) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 07/25/2011 09:23 AM, Blue Swirl wrote: > On Mon, Jul 25, 2011 at 3:21 PM, Anthony Liguori wrote: >> On 07/25/2011 07:18 AM, Avi Kivity wrote: >>> >>> On 07/25/2011 03:11 PM, Anthony Liguori wrote: >>>> >>>> On 07/25/2011 03:51 AM, Avi Kivity wrote: >>>>> >>>>> qemu_malloc() is type-unsafe as it returns a void pointer. Introduce >>>>> QEMU_NEW() (and QEMU_NEWZ()), which return the correct type. >>>> >>>> Just use g_new() and g_new0() >>>> >>> >>> These bypass qemu_malloc(). Are we okay with that? >> >> Yes. We can just make qemu_malloc use g_malloc. > > It would be also possible to make g_malloc() use qemu_malloc(). That > way we could keep the tracepoints which would lose their value with > g_malloc() otherwise. Or just add tracepoints to g_malloc()... But yeah, the point is, we ought to unify to a standard library function instead of inventing our own version of everything. Regards, Anthony Liguori >