Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

Jes Sorensen
2011-07-25T15:30:15Z

On 07/25/11 17:24, Avi Kivity wrote:
> On 07/25/2011 06:21 PM, Jes Sorensen wrote:
>> On 07/25/11 17:20, Avi Kivity wrote:
>> > On 07/25/2011 06:17 PM, Jes Sorensen wrote:
>> >> Using the commands consistently does have an impact, and at least
>> with
>> >> qemu_malloc() it is obvious what they are and how they behave. The
>> >> proposed macros on the other hand requires everybody to go look up
>> the
>> >> macro to find out what it is trying to do.
>> >
>> > That's true for every single function and macro that qemu defines.
>> >
>>
>> Of course, and every time it adds complexity for reading it. In this
>> particular case it seems to simply make the code worse for no gain.
>
> I guess type safety doesn't matter to you.

In my experience it's one of the lesser problems in the code.

Jes