From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 11/23] memory: add ioeventfd support Date: Mon, 25 Jul 2011 18:17:59 +0300 Message-ID: <4E2D8927.50504@redhat.com> References: <1311602584-23409-1-git-send-email-avi@redhat.com> <1311602584-23409-12-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: malc Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 07/25/2011 06:16 PM, malc wrote: > On Mon, 25 Jul 2011, Avi Kivity wrote: > > > As with the rest of the memory API, the caller associates an eventfd > > with an address, and the memory API takes care of registering or > > unregistering when the address is made visible or invisible to the > > guest. > > > > Signed-off-by: Avi Kivity > [..snip..] > > > +static bool memory_region_ioeventfd_before(MemoryRegionIoeventfd a, > > + MemoryRegionIoeventfd b) > > +{ > > + if (a.addr.start< b.addr.start) { > > + return true; > > + } else if (a.addr.start> b.addr.start) { > > + return false; > > + } else if (a.addr.size< b.addr.size) { > > + return true; > > + } else if (a.addr.size> b.addr.size) { > > + return false; > > + } else if (a.match_data< b.match_data) { > > + return true; > > + } else if (a.match_data> b.match_data) { > > + return false; > > + } else if (a.match_data) { > > + if (a.data< b.data) { > > + return true; > > + } else if (a.data> b.data) { > > + return false; > > + } > > + } > > + if (a.fd< b.fd) { > > + return true; > > + } else if (a.fd> b.fd) { > > + return false; > > + } > > Braces.. > Where? add? remove? -- error compiling committee.c: too many arguments to function