From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jes Sorensen <Jes.Sorensen@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()
Date: Mon, 25 Jul 2011 17:21:05 +0200
Message-ID: <4E2D89E1.20401@redhat.com>
References: <1311583872-362-1-git-send-email-avi@redhat.com>	<CAJSP0QUjLf1NS6uw0u5DwEaDEP6nW+CA+0MK4ka=yg5Nf55ftw@mail.gmail.com> <4E2D876C.3010300@redhat.com> <4E2D8896.7070100@codemonkey.ws> <4E2D8904.5080200@redhat.com> <4E2D89C7.8010004@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Anthony Liguori <anthony@codemonkey.ws>,
	Stefan Hajnoczi <stefanha@gmail.com>, kvm@vger.kernel.org,
	qemu-devel@nongnu.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:52466 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751802Ab1GYPXM (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 25 Jul 2011 11:23:12 -0400
In-Reply-To: <4E2D89C7.8010004@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 07/25/11 17:20, Avi Kivity wrote:
> On 07/25/2011 06:17 PM, Jes Sorensen wrote:
>> Using the commands consistently does have an impact, and at least with
>> qemu_malloc() it is obvious what they are and how they behave. The
>> proposed macros on the other hand requires everybody to go look up the
>> macro to find out what it is trying to do.
> 
> That's true for every single function and macro that qemu defines.
> 

Of course, and every time it adds complexity for reading it. In this
particular case it seems to simply make the code worse for no gain.

Jes