From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support Date: Mon, 25 Jul 2011 18:28:23 +0300 Message-ID: <4E2D8B97.5040407@redhat.com> References: <1311602584-23409-1-git-send-email-avi@redhat.com> <1311602584-23409-12-git-send-email-avi@redhat.com> <4E2D8927.50504@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: malc Return-path: Received: from mx1.redhat.com ([209.132.183.28]:10111 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507Ab1GYP2b (ORCPT ); Mon, 25 Jul 2011 11:28:31 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 07/25/2011 06:22 PM, malc wrote: > > > > + } > > > > + if (a.fd< b.fd) { > > > > + return true; > > > > + } else { > if (a.fd> b.fd) { > > > > + return false; > > > > + } > } CODING_STYLE permits braceless else if. > > > > > > Braces.. > > > > > > > Where? add? remove? > > > > You authored the coding_style document btw. It's CODING_STYLE. -- error compiling committee.c: too many arguments to function