From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support
Date: Mon, 25 Jul 2011 18:43:12 +0300
Message-ID: <4E2D8F10.9070009@redhat.com>
References: <1311602584-23409-1-git-send-email-avi@redhat.com> <1311602584-23409-12-git-send-email-avi@redhat.com> <alpine.LNX.2.00.1107251915270.3946@linmac> <4E2D8927.50504@redhat.com> <alpine.LNX.2.00.1107251921560.4044@linmac> <4E2D8B97.5040407@redhat.com> <alpine.LNX.2.00.1107251937240.4246@linmac>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
To: malc <av1474@comtv.ru>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:29192 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751380Ab1GYPnV (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 25 Jul 2011 11:43:21 -0400
In-Reply-To: <alpine.LNX.2.00.1107251937240.4246@linmac>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 07/25/2011 06:38 PM, malc wrote:
> On Mon, 25 Jul 2011, Avi Kivity wrote:
>
> >  On 07/25/2011 06:22 PM, malc wrote:
> >  >  >   >   >    +    }
> >  >  >   >   >    +    if (a.fd<    b.fd) {
> >  >  >   >   >    +        return true;
> >  >  >   >   >    +    } else {
> >  >                  if (a.fd>    b.fd) {
> >  >      >   >   >    +        return false;
> >  >      >   >   >    +    }
> >  >               }
> >
> >  CODING_STYLE permits braceless else if.
>
> The example uses it, the text however suggests it's illegal.

I'll post a patch.  It's perfectly reasonable IMO, and there ~1800 
instances in the tree.

-- 
error compiling committee.c: too many arguments to function