From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH 14/23] memory: transaction API
Date: Mon, 25 Jul 2011 14:16:26 -0500
Message-ID: <4E2DC10A.4040005@codemonkey.ws>
References: <1311602584-23409-1-git-send-email-avi@redhat.com> <1311602584-23409-15-git-send-email-avi@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-yw0-f46.google.com ([209.85.213.46]:48667 "EHLO
	mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751780Ab1GYTQ3 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 25 Jul 2011 15:16:29 -0400
Received: by ywe9 with SMTP id 9so2443244ywe.19
        for <kvm@vger.kernel.org>; Mon, 25 Jul 2011 12:16:28 -0700 (PDT)
In-Reply-To: <1311602584-23409-15-git-send-email-avi@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 07/25/2011 09:02 AM, Avi Kivity wrote:
> Allow changes to the memory hierarchy to be accumulated and
> made visible all at once.  This reduces computational effort,
> especially when an accelerator (e.g. kvm) is involved.
>
> Useful when a single register update causes multiple changes
> to an address space.
>
> Signed-off-by: Avi Kivity<avi@redhat.com>

What's the motivation for this?  Was this just because it seemed neat to 
do or did you run into a performance issue you were trying to solve?


> ---
>   memory.c |   20 ++++++++++++++++++++
>   memory.h |    8 ++++++++
>   2 files changed, 28 insertions(+), 0 deletions(-)
>
> diff --git a/memory.c b/memory.c
> index 009ad33..370e189 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -18,6 +18,8 @@
>   #include "kvm.h"
>   #include<assert.h>
>
> +unsigned memory_region_transaction_depth = 0;

Shouldn't this be static?

Regards,

Anthony Liguori

> +
>   typedef struct AddrRange AddrRange;
>
>   struct AddrRange {
> @@ -623,6 +625,10 @@ static void address_space_update_topology(AddressSpace *as)
>
>   static void memory_region_update_topology(void)
>   {
> +    if (memory_region_transaction_depth) {
> +        return;
> +    }
> +
>       if (address_space_memory.root) {
>           address_space_update_topology(&address_space_memory);
>       }
> @@ -631,6 +637,20 @@ static void memory_region_update_topology(void)
>       }
>   }
>
> +void memory_region_transaction_begin(void)
> +{
> +    ++memory_region_transaction_depth;
> +}
> +
> +void memory_region_transaction_commit(void)
> +{
> +    if (!memory_region_transaction_depth) {
> +        abort();
> +    }
> +    --memory_region_transaction_depth;
> +    memory_region_update_topology();
> +}
> +
>   void memory_region_init(MemoryRegion *mr,
>                           const char *name,
>                           uint64_t size)
> diff --git a/memory.h b/memory.h
> index e4c0ad1..cb3a9b6 100644
> --- a/memory.h
> +++ b/memory.h
> @@ -246,6 +246,14 @@ void memory_region_add_subregion_overlap(MemoryRegion *mr,
>   void memory_region_del_subregion(MemoryRegion *mr,
>                                    MemoryRegion *subregion);
>
> +/* Start a transaction; changes will be accumulated and made visible only
> + * when the transaction ends.
> + */
> +void memory_region_transaction_begin(void);
> +/* Commit a transaction and make changes visible to the guest.
> + */
> +void memory_region_transaction_commit(void);
> +
>   #endif
>
>   #endif