From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [RFC v5 86/86] 440fx: fix PAM, PCI holes
Date: Tue, 26 Jul 2011 11:01:04 +0300
Message-ID: <4E2E7440.3080208@redhat.com>
References: <1311180636-17012-1-git-send-email-avi@redhat.com>	<1311180636-17012-87-git-send-email-avi@redhat.com>
	<CAG7+5M1ZLJxaygTVVYW7gtNgZ2bsCptER350EqAZKaGD+n0rQA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
To: Eric Northup <digitaleric@google.com>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <CAG7+5M1ZLJxaygTVVYW7gtNgZ2bsCptER350EqAZKaGD+n0rQA@mail.gmail.com>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: </archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
List-Id: kvm.vger.kernel.org

On 07/26/2011 12:34 AM, Eric Northup wrote:
> On Wed, Jul 20, 2011 at 9:50 AM, Avi Kivity<avi@redhat.com>  wrote:
> [...]
> >  @@ -130,7 +137,13 @@ static void pc_init1(MemoryRegion *system_memory,
> >
> >       if (pci_enabled) {
> >           pci_bus = i440fx_init(&i440fx_state,&piix3_devfn, isa_irq,
> >  -                              system_memory, system_io, ram_size);
> >  +                              system_memory, system_io, ram_size,
> >  +                              0xe0000000, 0x1fe00000,
> >  +                              0x100000000 + above_4g_mem_size,
> >  +                              (sizeof(target_phys_addr_t) == 32
>
> sizeof(target_phys_addr_t) == 8 ?

Good catch.  Fixed

(== 4).

-- 
error compiling committee.c: too many arguments to function