From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCH 06/23] memory: rename MemoryRegion::has_ram_addr to ::terminates Date: Tue, 26 Jul 2011 12:59:33 +0300 Message-ID: <4E2E9005.7080802@redhat.com> References: <1311602584-23409-1-git-send-email-avi@redhat.com> <1311602584-23409-7-git-send-email-avi@redhat.com> <4E2DBC76.4050001@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:6981 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751156Ab1GZJ7i (ORCPT ); Tue, 26 Jul 2011 05:59:38 -0400 In-Reply-To: <4E2DBC76.4050001@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On 07/25/2011 09:56 PM, Anthony Liguori wrote: > On 07/25/2011 09:02 AM, Avi Kivity wrote: >> I/O regions will not have ram_addrs, so this is a better name. >> >> Signed-off-by: Avi Kivity > > Reviewed-by: Anthony Liguori > > Although it seems squashable. Yeah, I'm loath to squash across a conflicting commit though. -- error compiling committee.c: too many arguments to function