From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCH 13/23] memory: document the memory API Date: Tue, 26 Jul 2011 13:44:55 +0300 Message-ID: <4E2E9AA7.7030501@redhat.com> References: <1311602584-23409-1-git-send-email-avi@redhat.com> <1311602584-23409-14-git-send-email-avi@redhat.com> <4E2DC0BD.8090006@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58335 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751252Ab1GZKpA (ORCPT ); Tue, 26 Jul 2011 06:45:00 -0400 In-Reply-To: <4E2DC0BD.8090006@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On 07/25/2011 10:15 PM, Anthony Liguori wrote: >> +Region names >> +------------ >> + >> +Regions are assigned names by the constructor. For most regions >> these are >> +only used for debugging purposes, but RAM regions also use the name >> to identify >> +live migration sections. This means that RAM region names need to >> have ABI >> +stability. > + > > I don't think this needs to change for this series, but long term, > this is something that we need to better think through. > > Device ROM is part of the device. It shouldn't be migrated as RAM, it > should be included in the device state. Agreed; however I tries to limit the amount of functional change, especially with anything resembling an ABI. > > Would be nice to make this patch #1 in the series. Done. -- error compiling committee.c: too many arguments to function