From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 15/23] exec.c: initialize memory map
Date: Tue, 26 Jul 2011 13:55:56 +0300
Message-ID: <4E2E9D3C.60603@redhat.com>
References: <1311602584-23409-1-git-send-email-avi@redhat.com>
	<1311602584-23409-16-git-send-email-avi@redhat.com>
	<4E2DC14E.5080408@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
To: Anthony Liguori <anthony@codemonkey.ws>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <4E2DC14E.5080408@codemonkey.ws>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: </archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
List-Id: kvm.vger.kernel.org

On 07/25/2011 10:17 PM, Anthony Liguori wrote:
>> +static void memory_map_init(void)
>> +{
>> +    system_memory = qemu_malloc(sizeof(*system_memory));
>> +    memory_region_init(system_memory, "system", UINT64_MAX);
>
>
> Would be nice to #define MEM_REG_SIZE_ALL UINT64_MAX
>
> Without reading the docs, it seems like an odd bit of code otherwise.

It's really temporary.  It should come from the machine description and 
specify the processor's system bus width.

-- 
error compiling committee.c: too many arguments to function