From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCH 19/23] pc: move global memory map out of pc_init1() and into its callers Date: Tue, 26 Jul 2011 14:02:52 +0300 Message-ID: <4E2E9EDC.8020908@redhat.com> References: <1311602584-23409-1-git-send-email-avi@redhat.com> <1311602584-23409-20-git-send-email-avi@redhat.com> <4E2DCBE1.8030209@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:34366 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751296Ab1GZLC6 (ORCPT ); Tue, 26 Jul 2011 07:02:58 -0400 In-Reply-To: <4E2DCBE1.8030209@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On 07/25/2011 11:02 PM, Anthony Liguori wrote: > On 07/25/2011 09:03 AM, Avi Kivity wrote: >> Signed-off-by: Avi Kivity > > What's the rationale here? Removing globals and making dependencies explicit. -- error compiling committee.c: too many arguments to function