From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 04/23] memory: merge adjacent segments of a single
 memory region
Date: Tue, 26 Jul 2011 13:36:58 +0200
Message-ID: <4E2EA6DA.4000006@redhat.com>
References: <1311679582-11211-1-git-send-email-avi@redhat.com> <1311679582-11211-5-git-send-email-avi@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org,
	kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-yx0-f174.google.com ([209.85.213.174]:39137 "EHLO
	mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752977Ab1GZLhE (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 26 Jul 2011 07:37:04 -0400
Received: by yxi11 with SMTP id 11so161558yxi.19
        for <kvm@vger.kernel.org>; Tue, 26 Jul 2011 04:37:03 -0700 (PDT)
In-Reply-To: <1311679582-11211-5-git-send-email-avi@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 07/26/2011 01:26 PM, Avi Kivity wrote:
> +    while (i < view->nr) {
> +        j = i + 1;
> +        while (j < view->nr
> +               && can_merge(&view->ranges[j-1], &view->ranges[j])) {
> +            view->ranges[i].addr.size += view->ranges[j].addr.size;
> +            ++j;
> +        }
> +        ++i;

if (j != i) {

> +        memmove(&view->ranges[i], &view->ranges[j],
> +                (view->nr - j) * sizeof(view->ranges[j]));
> +        view->nr -= j - i;
> +    }

}


Paolo