From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 04/23] memory: merge adjacent segments of a single
 memory region
Date: Tue, 26 Jul 2011 13:51:32 +0200
Message-ID: <4E2EAA44.105@redhat.com>
References: <1311679582-11211-1-git-send-email-avi@redhat.com> <1311679582-11211-5-git-send-email-avi@redhat.com> <4E2EA6DA.4000006@redhat.com> <4E2EA71A.7000106@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org,
	kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:31345 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750946Ab1GZLvg (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 26 Jul 2011 07:51:36 -0400
In-Reply-To: <4E2EA71A.7000106@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 07/26/2011 01:38 PM, Avi Kivity wrote:
>>
>> if (j != i) {
>>
>>> +        memmove(&view->ranges[i], &view->ranges[j],
>>> +                (view->nr - j) * sizeof(view->ranges[j]));
>>> +        view->nr -= j - i;
>>> +    }
>>
>> }
>
> Seems to work both ways?

Sure, but you're pointlessly memmove-ing memory over itself.  I'm not 
sure how many segments a single memory region will usually have, but 
it's better to be safe.

Paolo