From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] dev-assignment: handle device with incorrect PCIe Cap structure size Date: Wed, 27 Jul 2011 12:27:51 +0300 Message-ID: <4E2FDA17.6090809@redhat.com> References: <20110726203722.39565.29092.stgit@dddsys0.bos.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, alex.williamson@redhat.com, mst@redhat.com To: Donald Dutile Return-path: Received: from mx1.redhat.com ([209.132.183.28]:8937 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753570Ab1G0J1z (ORCPT ); Wed, 27 Jul 2011 05:27:55 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6R9Rtog013257 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 27 Jul 2011 05:27:55 -0400 In-Reply-To: <20110726203722.39565.29092.stgit@dddsys0.bos.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/27/2011 01:08 AM, Donald Dutile wrote: > The bcm5761 provides a PCIe Cap structure (capid=0x10) > that is invalid, providing one that is 8 bytes shorter > than the v2 PCIe spec defines. > This leads to a memory corruption when mapped for device-assigment. > > Add a check in assigned_device_pci_cap_init() to correct > this hw error for this device, and try to catch other ones > and print warnings if they exists. Applied, thanks. -- error compiling committee.c: too many arguments to function