From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: Really fix HV_X64_MSR_APIC_ASSIST_PAGE Date: Wed, 27 Jul 2011 14:41:11 +0300 Message-ID: <4E2FF957.1040207@redhat.com> References: <1311406305-24523-1-git-send-email-mikew@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Mike Waychison Return-path: In-Reply-To: <1311406305-24523-1-git-send-email-mikew@google.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 07/23/2011 10:31 AM, Mike Waychison wrote: > Commit 0945d4b228 tried to fix the get_msr path for the > HV_X64_MSR_APIC_ASSIST_PAGE msr, but was poorly tested. We should be > returning 0 if the read succeeded, and passing the value back to the > caller via the pdata out argument, not returning the value directly. Applied, thanks. -- error compiling committee.c: too many arguments to function