From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org, yoshikawa.takuya@oss.ntt.co.jp
Subject: Re: [PATCH 4/4] KVM: x86 emulator: Make x86_decode_insn() return proper macros
Date: Sun, 31 Jul 2011 11:48:40 +0300 [thread overview]
Message-ID: <4E3516E8.9040100@redhat.com> (raw)
In-Reply-To: <20110730180334.2f50c753.takuya.yoshikawa@gmail.com>
On 07/30/2011 12:03 PM, Takuya Yoshikawa wrote:
> From: Takuya Yoshikawa<yoshikawa.takuya@oss.ntt.co.jp>
>
> Return EMULATION_OK/FAILED consistently. Also treat instruction fetch
> errors, not restricted to X86EMUL_UNHANDLEABLE, as EMULATION_FAILED;
> although this cannot happen in practice, the current logic will continue
> the emulation even if the decoder fails to fetch the instruction.
In fact it can happen in practice, but not through normal usage. For
example, one vcpu can execute an instruction which traps into the
emulator, while another vcpu changes the page tables to make the
instruction unfetchable.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-07-31 8:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-30 8:58 [PATCH 0/4] KVM: x86 emulator: Clean up decoder a bit Takuya Yoshikawa
2011-07-30 9:00 ` [PATCH 1/4] KVM: x86 emulator: Use ctxt->_eip directly in do_insn_fetch_byte() Takuya Yoshikawa
2011-07-30 9:01 ` [PATCH 2/4] KVM: x86 emulator: Drop _size argument from insn_fetch() Takuya Yoshikawa
2011-07-30 9:02 ` [PATCH 3/4] KVM: x86 emulator: Let compiler know insn_fetch() rarely fails Takuya Yoshikawa
2011-07-30 9:03 ` [PATCH 4/4] KVM: x86 emulator: Make x86_decode_insn() return proper macros Takuya Yoshikawa
2011-07-31 8:48 ` Avi Kivity [this message]
2011-07-31 13:48 ` Takuya Yoshikawa
2011-07-31 8:46 ` [PATCH 0/4] KVM: x86 emulator: Clean up decoder a bit Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3516E8.9040100@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox