From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 03/39] vga: convert vga and its derivatives to the memory API Date: Sun, 31 Jul 2011 21:46:09 +0300 Message-ID: <4E35A2F1.7060807@redhat.com> References: <1312135082-31985-1-git-send-email-avi@redhat.com> <1312135082-31985-4-git-send-email-avi@redhat.com> <4E35A229.9020800@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" To: Jan Kiszka Return-path: In-Reply-To: <4E35A229.9020800@web.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 07/31/2011 09:42 PM, Jan Kiszka wrote: > On 2011-07-31 19:57, Avi Kivity wrote: > > Convert all vga memory to the memory API. Note we need to fall back to > > get_system_memory(), since the various buses don't pass the vga window > > as a memory region. > > > > We no longer need to sync the dirty bitmap of the cirrus mapped memory > > banks, since the memory API takes care of that for us. > > > > [jan: fix vga-pci logging] > > grub2 in graphical mode (likely via VBE) is still broken under kvm. Sorry, I forgot about it. Will take a look. > How > did you try to address the flush-before-remap issue? > I haven't. How does "unconditionally dirty the remapped slot" sound? I think it isn't introduced by this patchset, yes? -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.