From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 03/39] vga: convert vga and its derivatives to the memory API Date: Sun, 31 Jul 2011 22:06:00 +0300 Message-ID: <4E35A798.10502@redhat.com> References: <1312135082-31985-1-git-send-email-avi@redhat.com> <1312135082-31985-4-git-send-email-avi@redhat.com> <4E35A229.9020800@web.de> <4E35A2F1.7060807@redhat.com> <4E35A371.9080802@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" To: Jan Kiszka Return-path: In-Reply-To: <4E35A371.9080802@web.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 07/31/2011 09:48 PM, Jan Kiszka wrote: > > > > I haven't. How does "unconditionally dirty the remapped slot" sound? > > > > I think it isn't introduced by this patchset, yes? > > The patch removes the explicit sync from the cirrus code. But the > underlying issue is older of course. > Ah. So I'll detect that condition in memory.c; we get that bug fixed for all potential callers. I'll leave the race condition until later, since it wasn't introduced by this patchset. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.