From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCH 09/39] Integrate I/O memory regions into qemu Date: Mon, 01 Aug 2011 09:05:47 +0300 Message-ID: <4E36423B.1080902@redhat.com> References: <1312135082-31985-1-git-send-email-avi@redhat.com> <1312135082-31985-10-git-send-email-avi@redhat.com> <4E35F128.2020309@twiddle.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" To: Richard Henderson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:13920 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753350Ab1HAGF4 (ORCPT ); Mon, 1 Aug 2011 02:05:56 -0400 In-Reply-To: <4E35F128.2020309@twiddle.net> Sender: kvm-owner@vger.kernel.org List-ID: On 08/01/2011 03:19 AM, Richard Henderson wrote: > On 07/31/2011 10:57 AM, Avi Kivity wrote: > > + system_io = qemu_malloc(sizeof(*system_io)); > > + memory_region_init(system_memory, "io", 65536); > > + set_system_io_map(system_io); > > Cut-paste error on that second line. > Well spotted; the cpu also saw this and the fix is in patch 10, which I forgot to squash into this. I'll post a squashed version. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.