From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [RFC PATCH] KVM-test: Add subtest: usb
Date: Mon, 01 Aug 2011 09:33:57 +0200
Message-ID: <4E3656E5.4070000@redhat.com>
References: <20110729045302.16386.89319.stgit@t>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: autotest@test.kernel.org, kvm@vger.kernel.org
To: Amos Kong <akong@redhat.com>
Return-path: <autotest-bounces@test.kernel.org>
In-Reply-To: <20110729045302.16386.89319.stgit@t>
List-Unsubscribe: <http://test.kernel.org/cgi-bin/mailman/listinfo/autotest>,
	<mailto:autotest-request@test.kernel.org?subject=unsubscribe>
List-Archive: <http://test.kernel.org/pipermail/autotest>
List-Post: <mailto:autotest@test.kernel.org>
List-Help: <mailto:autotest-request@test.kernel.org?subject=help>
List-Subscribe: <http://test.kernel.org/cgi-bin/mailman/listinfo/autotest>,
	<mailto:autotest-request@test.kernel.org?subject=subscribe>
Sender: autotest-bounces@test.kernel.org
Errors-To: autotest-bounces@test.kernel.org
List-Id: kvm.vger.kernel.org

On 07/29/11 06:53, Amos Kong wrote:
> This test adds a usb storage for the guest, and do some check from monitor and
> inside the guest.
> It's not very stable, could you help to review if something is wrong?

"Not stable" means what exactly?

> +    output = session.get_command_output("lsusb")
> +    #no bus specified, default using "usb.0" for "usb-storage"
> +    if "ID 0000:0000" not in output:
> +        logging.debug(output)
> +        raise error.TestFail("No 'ID 0000:0000' in the output of 'lsusb'")

You can use "lsusb -v" here, then you get something better to match. 
Also lsusb does some more usb requests then.  Should also check for 
errors in the lsusb output.

> +    output = session.get_command_output("fdisk -l")
> +    if params.get("fdisk_string") not in output:
> +        logging.debug(output)
> +        raise error.TestFail("Could not realise the usb device")
> +
> +    error.context("Formating usb disk")
> +    dev_list = session.get_command_output("ls /dev/sd[a-z]")
> +    session.cmd("yes |mkfs %s" % dev_list.split()[-1],
> +                timeout=int(params.get("format_timeout")))

You can look at /dev/disk/by-path/ to figure which /dev/sd<x> the usb 
flashdrive is.

cheers,
   Gerd