From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 20/39] virtio-pci: convert to memory API Date: Mon, 01 Aug 2011 12:35:44 +0300 Message-ID: <4E367370.6070100@redhat.com> References: <1312135082-31985-1-git-send-email-avi@redhat.com> <1312135082-31985-21-git-send-email-avi@redhat.com> <20110801082600.GD5439@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:11743 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753088Ab1HAJft (ORCPT ); Mon, 1 Aug 2011 05:35:49 -0400 In-Reply-To: <20110801082600.GD5439@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/01/2011 11:26 AM, Michael S. Tsirkin wrote: > > > > static void virtio_write_config(PCIDevice *pci_dev, uint32_t address, > > uint32_t val, int len) > > { > > VirtIOPCIProxy *proxy = DO_UPCAST(VirtIOPCIProxy, pci_dev, pci_dev); > > + VirtIODevice *vdev = proxy->vdev; > > > > if (PCI_COMMAND == address) { > > if (!(val& PCI_COMMAND_MASTER)) { > > @@ -525,6 +503,9 @@ static void virtio_write_config(PCIDevice *pci_dev, uint32_t address, > > } > > } > > } > > + if (address == PCI_BASE_ADDRESS_0&& vdev->config_len) { > > + vdev->get_config(vdev, vdev->config); > > + } > > > > pci_default_write_config(pci_dev, address, val, len); > > msix_write_config(pci_dev, address, val, len); > > I'm not really sure why did we get the config on map, > specifically - Anthony, do you know? > But if we want to do that, memory space enable might > be a better place. Or maybe we just want a callback on > map. Just because a memory region becomes visible to the cpu is no reason to have a callback. From the device perspective, it can't tell that it happened. -- error compiling committee.c: too many arguments to function