From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [RFC PATCH v2 1/3] separate thread for VM migration Date: Tue, 02 Aug 2011 09:44:18 +0200 Message-ID: <4E37AAD2.2090706@redhat.com> References: <4E3673E3.1000201@redhat.com> <4E371406.7040109@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, Juan Quintela , mtosatti@redhat.com To: Umesh Deshpande Return-path: Received: from mail-gx0-f174.google.com ([209.85.161.174]:38180 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751856Ab1HBHo0 (ORCPT ); Tue, 2 Aug 2011 03:44:26 -0400 Received: by gxk21 with SMTP id 21so3901005gxk.19 for ; Tue, 02 Aug 2011 00:44:26 -0700 (PDT) In-Reply-To: <4E371406.7040109@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/01/2011 11:00 PM, Umesh Deshpande wrote: >> > I kept this in migration.c to call qemu_savevm_state_begin. (The way it > is done currently. i.e. to keep access to FdMigrationState in migration.c) > Calling it from buffered_file.c would be inconsistent in that sense. or > we will have to call it from the iothread before spawning the migration > thread. Right, I missed that. Perhaps you can call it the first time put_ready is called. > Also why is the separation between FdMigrationState and QEMUFileBuffered > is required. Is QEMUFileBuffered designed to use also for things other > than migration? No, but let's keep it this way for now. It may be an annoyance, but it also helps making a reusable architecture, and it can probably be cleaned up substantially with thread support. Paolo