Re: [PATCH] cpu hotplug issue

Avi Kivity
2011-07-21T13:15:16Z

On 07/21/2011 04:08 PM, Vasilis Liaskovitis wrote:
> Hi,
>
> thanks for looking at this closer.
>
> On Thu, Jul 21, 2011 at 1:33 PM, Gleb Natapov<gleb@redhat.com> wrote:
>
> >> Note that there is probably another bug in qemu-kvm/master regarding
> >> acpi-udev event delivery for
> >> a cpu-hotplug event (cpu_set in the qemu_monitor no longer triggers
> >> the event in the guest, see
> >> first issue in my original mail). This patch does not address that issue.
> >>
> > Did this work in qemu-0.13?
>
> yes, the acpi-event delivery worked fine for me in 0.13.0
>
> I also tried to separately bisect the acpi-udev delivery issue between
> 0.13.0 and qemu-kvm/master but ended up
> with a big merge commit as the culprit. Not sure if it would help.

You can bisect it further. If you tag the bad commit "bad", then you do

$ git bisect start bad^2 $(git merge-base bad^1 bad^2)

(for each commit bisect feeds you:)
$ git merge --no-commit bad^1
<test>
$ git checkout -f
$ git bisect <good|bad>

What this does is bisect all commits added by the merge, but first
re-does the merge before testing. You shouldn't have any conflicts
during these merging.

It is recommended to set up ccache to reduce build time, as those merges
force a full rebuild every time.

--
error compiling committee.c: too many arguments to function