From: Richard Henderson <rth@twiddle.net>
To: Avi Kivity <avi@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH] memory: use signed arithmetic
Date: Tue, 02 Aug 2011 14:59:47 -0700 [thread overview]
Message-ID: <4E387353.9020806@twiddle.net> (raw)
In-Reply-To: <1312318249-7011-1-git-send-email-avi@redhat.com>
On 08/02/2011 01:50 PM, Avi Kivity wrote:
> struct AddrRange {
> - uint64_t start;
> - uint64_t size;
> + int64_t start;
> + int64_t size;
I'm must say I'm not keen on this. My primary objection is that
a "range" can no longer properly represent the entire address space.
Or, indeed, anything in the second half of it.
It sounds like your problem would be better solved by re-arranging
things such that you perform X < Y comparisons rather than DELTA < 0.
r~
next prev parent reply other threads:[~2011-08-02 21:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 20:50 [PATCH] memory: use signed arithmetic Avi Kivity
2011-08-02 21:15 ` [Qemu-devel] " malc
2011-08-02 21:21 ` Avi Kivity
2011-08-02 21:59 ` Richard Henderson [this message]
2011-08-02 22:06 ` Avi Kivity
2011-08-02 22:15 ` Richard Henderson
2011-08-03 8:26 ` Avi Kivity
2011-08-03 11:48 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E387353.9020806@twiddle.net \
--to=rth@twiddle.net \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox