From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Subject: Re: [PATCH v2 08/12] KVM: MMU: fast prefetch spte on invlpg path
Date: Wed, 03 Aug 2011 14:03:14 +0800
Message-ID: <4E38E4A2.4080705@cn.fujitsu.com>
References: <4E37DA49.1040000@cn.fujitsu.com> <4E37DB3E.2040306@cn.fujitsu.com> <20110802183657.GA6813@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
	KVM <kvm@vger.kernel.org>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cn.fujitsu.com ([222.73.24.84]:49515 "EHLO song.cn.fujitsu.com"
	rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1754808Ab1HCGBR (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 3 Aug 2011 02:01:17 -0400
In-Reply-To: <20110802183657.GA6813@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 08/03/2011 02:36 AM, Marcelo Tosatti wrote:

>>  	mask.cr0_wp = mask.cr4_pae = mask.nxe = 1;
>> diff --git a/arch/x86/kvm/paging_tmpl.h b/arch/x86/kvm/paging_tmpl.h
>> index 0f915b5..3466229 100644
>> --- a/arch/x86/kvm/paging_tmpl.h
>> +++ b/arch/x86/kvm/paging_tmpl.h
>> @@ -666,20 +666,22 @@ static void FNAME(invlpg)(struct kvm_vcpu *vcpu, gva_t gva)
>>  {
>>  	struct kvm_shadow_walk_iterator iterator;
>>  	struct kvm_mmu_page *sp;
>> -	gpa_t pte_gpa = -1;
>>  	int level;
>>  	u64 *sptep;
>>  
>>  	vcpu_clear_mmio_info(vcpu, gva);
>> +	mmu_topup_memory_caches(vcpu);
> 
> Should handle failure.
> 

Yes, thanks Marcelo! I will fix it.