From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 20/39] virtio-pci: convert to memory API Date: Wed, 03 Aug 2011 18:23:41 +0300 Message-ID: <4E3967FD.8000301@redhat.com> References: <1312135082-31985-1-git-send-email-avi@redhat.com> <1312135082-31985-21-git-send-email-avi@redhat.com> <20110801082600.GD5439@redhat.com> <4E367370.6070100@redhat.com> <20110801102322.GF5439@redhat.com> <20110803151635.GA15804@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45294 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753205Ab1HCPXq (ORCPT ); Wed, 3 Aug 2011 11:23:46 -0400 In-Reply-To: <20110803151635.GA15804@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/03/2011 06:16 PM, Michael S. Tsirkin wrote: > > > > Well, the reason we have this logic here, I think, is > > to make sure it runs before the guest accesses > > the configuration with a write access. > > > > I'm not sure why we don't do this in the init > > callback - Anthony? > > So the following should do this. > Anthony, could you ack please? > > Avi, this is on top of the memory API branch. > But since it's not exactly the same, > maybe this should go in *before* the memory API > patches, to make it easier to bisect etc? > > You decide. How can I decide? This is your area. I'll be happy to rebase if needed. -- error compiling committee.c: too many arguments to function