From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] [PATCH] memory: synchronize dirty bitmap before unmapping a range Date: Fri, 05 Aug 2011 11:47:30 -0500 Message-ID: <4E3C1EA2.5000709@codemonkey.ws> References: <1312141678-5141-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, Jan Kiszka , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mail-yx0-f174.google.com ([209.85.213.174]:40574 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750855Ab1HEQrf (ORCPT ); Fri, 5 Aug 2011 12:47:35 -0400 Received: by yxj19 with SMTP id 19so1568083yxj.19 for ; Fri, 05 Aug 2011 09:47:34 -0700 (PDT) In-Reply-To: <1312141678-5141-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/31/2011 02:47 PM, Avi Kivity wrote: > When a range is being unmapped, ask accelerators (e.g. kvm) to synchronize the > dirty bitmap to avoid losing information forever. > > Fixes grub2 screen update. > > Signed-off-by: Avi Kivity Applied. Thanks. Regards, Anthony Liguori > --- > > Please apply before the PCI batch to avoid bisectability issues (and don't > pull, since that removes ordering). > > memory.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/memory.c b/memory.c > index 5c6e63d..5f20320 100644 > --- a/memory.c > +++ b/memory.c > @@ -245,6 +245,10 @@ static void as_memory_range_add(AddressSpace *as, FlatRange *fr) > > static void as_memory_range_del(AddressSpace *as, FlatRange *fr) > { > + if (fr->dirty_log_mask) { > + cpu_physical_sync_dirty_bitmap(fr->addr.start, > + fr->addr.start + fr->addr.size); > + } > cpu_register_physical_memory(fr->addr.start, fr->addr.size, > IO_MEM_UNASSIGNED); > }