* [PATCH master+STABLE-0.15] Fix default accelerator when configured with --disable-kvm
@ 2011-08-05 8:50 Daniel P. Berrange
2011-08-05 17:10 ` Marcelo Tosatti
0 siblings, 1 reply; 5+ messages in thread
From: Daniel P. Berrange @ 2011-08-05 8:50 UTC (permalink / raw)
To: kvm; +Cc: avi, mtosatti, Daniel P. Berrange
From: "Daniel P. Berrange" <berrange@redhat.com>
The default accelerator is hardcoded to 'kvm'. This is a fine
default for qemu-kvm normally, but if the user built with
./configure --disable-kvm, then the resulting binaries will
not work by default
* vl.c: Default to 'tcg' unless CONFIG_KVM is defined
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
vl.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index 7ae549e..28fd2f3 100644
--- a/vl.c
+++ b/vl.c
@@ -1953,8 +1953,13 @@ static int configure_accelerator(void)
}
if (p == NULL) {
+#ifdef CONFIG_KVM
/* Use the default "accelerator", kvm */
p = "kvm";
+#else
+ /* Use the default "accelerator", tcg */
+ p = "tcg";
+#endif
}
while (!accel_initalised && *p != '\0') {
--
1.7.6
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH master+STABLE-0.15] Fix default accelerator when configured with --disable-kvm
2011-08-05 8:50 [PATCH master+STABLE-0.15] Fix default accelerator when configured with --disable-kvm Daniel P. Berrange
@ 2011-08-05 17:10 ` Marcelo Tosatti
2011-08-05 17:27 ` Anthony Liguori
0 siblings, 1 reply; 5+ messages in thread
From: Marcelo Tosatti @ 2011-08-05 17:10 UTC (permalink / raw)
To: Daniel P. Berrange; +Cc: kvm, avi
On Fri, Aug 05, 2011 at 09:50:29AM +0100, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@redhat.com>
>
> The default accelerator is hardcoded to 'kvm'. This is a fine
> default for qemu-kvm normally, but if the user built with
> ./configure --disable-kvm, then the resulting binaries will
> not work by default
>
> * vl.c: Default to 'tcg' unless CONFIG_KVM is defined
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH master+STABLE-0.15] Fix default accelerator when configured with --disable-kvm
2011-08-05 17:10 ` Marcelo Tosatti
@ 2011-08-05 17:27 ` Anthony Liguori
0 siblings, 0 replies; 5+ messages in thread
From: Anthony Liguori @ 2011-08-05 17:27 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: Daniel P. Berrange, kvm, avi
On 08/05/2011 12:10 PM, Marcelo Tosatti wrote:
> On Fri, Aug 05, 2011 at 09:50:29AM +0100, Daniel P. Berrange wrote:
>> From: "Daniel P. Berrange"<berrange@redhat.com>
>>
>> The default accelerator is hardcoded to 'kvm'. This is a fine
>> default for qemu-kvm normally, but if the user built with
>> ./configure --disable-kvm, then the resulting binaries will
>> not work by default
>>
>> * vl.c: Default to 'tcg' unless CONFIG_KVM is defined
>>
>> Signed-off-by: Daniel P. Berrange<berrange@redhat.com>
>
> Applied, thanks.
FYI, you can now do the same thing by just patching
sysconfig/target-x86_64.conf. I just modify my
/usr/local/etc/qemu/target-x86_64.conf and now even with qemu.git, I get
kvm enablement by default.
diff --git a/sysconfigs/target/target-x86_64.conf
b/sysconfigs/target/target-x86
index 43ad282..2eabef9 100644
--- a/sysconfigs/target/target-x86_64.conf
+++ b/sysconfigs/target/target-x86_64.conf
@@ -84,3 +84,5 @@
xlevel = "0x80000008"
model_id = "AMD Opteron 23xx (Gen 3 Class Opteron)"
+[machine]
+ accel = "kvm:tcg"
Regards,
Anthony Liguori
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH master+STABLE-0.15] Fix default accelerator when configured with --disable-kvm
@ 2011-08-04 14:02 Daniel P. Berrange
2011-08-04 20:15 ` Marcelo Tosatti
0 siblings, 1 reply; 5+ messages in thread
From: Daniel P. Berrange @ 2011-08-04 14:02 UTC (permalink / raw)
To: kvm; +Cc: avi, Daniel P. Berrange
From: "Daniel P. Berrange" <berrange@redhat.com>
The default accelerator is hardcoded to 'kvm'. This is a fine
default for qemu-kvm normally, but if the user built with
./configure --disable-kvm, then the resulting binaries will
not work by default
* vl.c: Default to 'tcg' unless CONFIG_KVM is defined
---
vl.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index 7ae549e..28fd2f3 100644
--- a/vl.c
+++ b/vl.c
@@ -1953,8 +1953,13 @@ static int configure_accelerator(void)
}
if (p == NULL) {
+#ifdef CONFIG_KVM
/* Use the default "accelerator", kvm */
p = "kvm";
+#else
+ /* Use the default "accelerator", tcg */
+ p = "tcg";
+#endif
}
while (!accel_initalised && *p != '\0') {
--
1.7.6
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH master+STABLE-0.15] Fix default accelerator when configured with --disable-kvm
2011-08-04 14:02 Daniel P. Berrange
@ 2011-08-04 20:15 ` Marcelo Tosatti
0 siblings, 0 replies; 5+ messages in thread
From: Marcelo Tosatti @ 2011-08-04 20:15 UTC (permalink / raw)
To: Daniel P. Berrange; +Cc: kvm, avi
On Thu, Aug 04, 2011 at 03:02:24PM +0100, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@redhat.com>
>
> The default accelerator is hardcoded to 'kvm'. This is a fine
> default for qemu-kvm normally, but if the user built with
> ./configure --disable-kvm, then the resulting binaries will
> not work by default
Signed-off-by, please.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-08-05 17:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-05 8:50 [PATCH master+STABLE-0.15] Fix default accelerator when configured with --disable-kvm Daniel P. Berrange
2011-08-05 17:10 ` Marcelo Tosatti
2011-08-05 17:27 ` Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2011-08-04 14:02 Daniel P. Berrange
2011-08-04 20:15 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox