From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH v3 02/39] pci: add API to get a BAR's
 mapped address
Date: Sun, 07 Aug 2011 11:22:59 +0300
Message-ID: <4E3E4B63.3020108@redhat.com>
References: <1312463195-13605-1-git-send-email-avi@redhat.com>
	<1312463195-13605-3-git-send-email-avi@redhat.com>
	<4E3BF5E9.5050504@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <4E3BF5E9.5050504@codemonkey.ws>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: </archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
List-Id: kvm.vger.kernel.org

On 08/05/2011 04:53 PM, Anthony Liguori wrote:
> On 08/04/2011 08:05 AM, Avi Kivity wrote:
>> This is a hack, for devices that have a back-channel to read this
>> address back outside the normal configuration mechanisms, such
>> as VMware svga.
>>
>> Reviewed-by: Richard Henderson<rth@twiddle.net>
>> Signed-off-by: Avi Kivity<avi@redhat.com>
>
> Can we add a comment to the header file to this effect?

I think I'll just update the changelog.  There  is nothing hacky about 
the API - it just reads documented PCI registers - it's the hardware 
that needs the API that's hacky, since the value in the registers 
doesn't mean much.

-- 
error compiling committee.c: too many arguments to function