From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v4 07/10] ARM: KVM: Emulation framework and CP15 emulation Date: Tue, 09 Aug 2011 14:39:01 +0300 Message-ID: <4E411C55.3040902@redhat.com> References: <20110806103821.27198.41231.stgit@localhost6.localdomain6> <20110806103949.27198.28630.stgit@localhost6.localdomain6> <4E411740.6050007@redhat.com> <7566E2E1-F1E4-4683-9DA5-271738A5A14D@virtualopensystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Christoffer Dall , kvm@vger.kernel.org, catalin.marinas@arm.com, tech@virtualopensystems.com, android-virt@lists.cs.columbia.edu To: Christoffer Dall Return-path: Received: from mx1.redhat.com ([209.132.183.28]:40196 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753308Ab1HILjV (ORCPT ); Tue, 9 Aug 2011 07:39:21 -0400 In-Reply-To: <7566E2E1-F1E4-4683-9DA5-271738A5A14D@virtualopensystems.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/09/2011 02:34 PM, Christoffer Dall wrote: > > > >> + > >> +/** > >> + * emulate_cp15_c15_access -- emulates cp15 accesses for CRn == 15 > >> + * @vcpu: The VCPU pointer > >> + * @p: The coprocessor parameters struct pointer holding trap inst. details > >> + * > >> + * The CP15 c15 register is implementation defined, but some guest kernels > >> + * attempt to read/write a diagnostics register here. We always return 0 and > >> + * ignore writes and hope for the best. This may need to be refined. > >> + */ > >> +static int emulate_cp15_c15_access(struct kvm_vcpu *vcpu, > >> + struct coproc_params *p) > >> +{ > >> + trace_kvm_emulate_cp15_imp(p->Op1, p->Rt1, p->CRn, p->CRm, > >> + p->Op2, p->is_write); > > > > _imp? > > implementation defined co-processor 15 operations. Took me 10 minutes to dig out from memory, so, ok, this is not super informative or clear:) Will try to come up with something better or the right comment somewhere or something. > Ah, okay. It's not related to the kvm implementation, it's architecturally implementation defined. -- error compiling committee.c: too many arguments to function