From: Avi Kivity <avi@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Sasha Levin <levinsasha928@gmail.com>,
penberg@kernel.org, asias.hejun@gmail.com,
prasadjoshi124@gmail.com, gorcunov@gmail.com,
kvm@vger.kernel.org
Subject: Re: [PATCH] kvm tools: Use correct size for VESA memory BAR
Date: Tue, 09 Aug 2011 19:46:01 +0300 [thread overview]
Message-ID: <4E416449.5020205@redhat.com> (raw)
In-Reply-To: <20110809153912.GB7867@elte.hu>
On 08/09/2011 06:39 PM, Ingo Molnar wrote:
> * Sasha Levin<levinsasha928@gmail.com> wrote:
>
> > This patch makes BAR 1 16k, instead of BAR0 - which is the PIO bar.
> >
>
> This changelog is missing some key information:
>
> - how did you find the bug (by chance via code review or did you see
> some actual badness?)
>
> - what practical effect (if any) did you see from this patch?
>
> - what practical effect (if any) do you expect others to see from this patch?
>
> I suspect this patch is only for completeness/correctness but has no
> practical effect - but that's a guess.
>
My guess would be that seabios tried to lay out the BARs and had trouble
fitting a 16k pio bar in the small PCI pio region.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-08-09 16:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 15:21 [PATCH] kvm tools: Use correct size for VESA memory BAR Sasha Levin
2011-08-09 15:39 ` Ingo Molnar
2011-08-09 16:46 ` Avi Kivity [this message]
2011-08-10 6:13 ` Pekka Enberg
2011-08-10 17:46 ` David Evensky
-- strict thread matches above, loose matches on Subject: below --
2011-08-11 9:04 [PATCH] kvm tools: Fix IRQ mapping Sasha Levin
2011-08-11 9:04 ` [PATCH] kvm tools: Use correct size for VESA memory bar Sasha Levin
2011-08-11 9:49 ` walimis
2011-08-11 11:55 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E416449.5020205@redhat.com \
--to=avi@redhat.com \
--cc=asias.hejun@gmail.com \
--cc=gorcunov@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=prasadjoshi124@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox