From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm tools: Use correct size for VESA memory BAR Date: Tue, 09 Aug 2011 19:46:01 +0300 Message-ID: <4E416449.5020205@redhat.com> References: <1312903262-8212-1-git-send-email-levinsasha928@gmail.com> <20110809153912.GB7867@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Sasha Levin , penberg@kernel.org, asias.hejun@gmail.com, prasadjoshi124@gmail.com, gorcunov@gmail.com, kvm@vger.kernel.org To: Ingo Molnar Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41353 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752673Ab1HIQqO (ORCPT ); Tue, 9 Aug 2011 12:46:14 -0400 In-Reply-To: <20110809153912.GB7867@elte.hu> Sender: kvm-owner@vger.kernel.org List-ID: On 08/09/2011 06:39 PM, Ingo Molnar wrote: > * Sasha Levin wrote: > > > This patch makes BAR 1 16k, instead of BAR0 - which is the PIO bar. > > > > This changelog is missing some key information: > > - how did you find the bug (by chance via code review or did you see > some actual badness?) > > - what practical effect (if any) did you see from this patch? > > - what practical effect (if any) do you expect others to see from this patch? > > I suspect this patch is only for completeness/correctness but has no > practical effect - but that's a guess. > My guess would be that seabios tried to lay out the BARs and had trouble fitting a 16k pio bar in the small PCI pio region. -- error compiling committee.c: too many arguments to function