From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH 07/10] KVM: PPC: Add PAPR hypercall code for PR mode Date: Tue, 09 Aug 2011 18:51:55 +0200 Message-ID: <4E4165AB.8030704@suse.de> References: <1312907508-14599-1-git-send-email-agraf@suse.de> <1312907508-14599-8-git-send-email-agraf@suse.de> <4E416315.2080800@redhat.com> <4E41646C.1070500@suse.de> <4E41651C.7050709@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-ppc@vger.kernel.org, linuxppc-dev@ozlabs.org, kvm@vger.kernel.org, paulus@samba.org To: Avi Kivity Return-path: In-Reply-To: <4E41651C.7050709@redhat.com> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 08/09/2011 06:49 PM, Avi Kivity wrote: > On 08/09/2011 07:46 PM, Alexander Graf wrote: >> On 08/09/2011 06:40 PM, Avi Kivity wrote: >>> On 08/09/2011 07:31 PM, Alexander Graf wrote: >>>> When running a PAPR guest, we need to handle a few hypercalls in >>>> kernel space, >>>> most prominently the page table invalidation (to sync the shadows). >>>> >>>> So this patch adds handling for a few PAPR hypercalls to PR mode >>>> KVM. I tried >>>> to share the code with HV mode, but it ended up being a lot easier >>>> this way >>>> around, as the two differ too much in those details. >>>> >>>> >>>> +++ b/arch/powerpc/kvm/book3s_pr_papr.c >>>> @@ -0,0 +1,158 @@ >>>> +/* >>>> + * Copyright (C) 2011. Freescale Inc. All rights reserved. >>>> + * >>>> + * Authors: >>>> + * Alexander Graf >>>> + * Paul Mackerras >>>> + * >>>> + * Description: >>>> + * >>>> + * Hypercall handling for running PAPR guests in PR KVM on Book 3S >>>> + * processors. >>>> + * >>>> + * This program is free software; you can redistribute it and/or >>>> modify >>>> + * it under the terms of the GNU General Public License, version >>>> 2, as >>>> + * published by the Free Software Foundation. >>>> + */ >>> >>> Copyright freescale, authors Paul and yourself? >> >> Yeah, I'm reasonably clueless when it comes to legal stuff. This code >> is inspired by Paul's, but is mostly rewritten since it's so tied >> into the virtual MMU. What would the copyright be in that case? > > Just put your own (or your employers'). If someone contributed to the > code they can add their copyrights (or ask you do do it before > inclusion). > > It would be good to get Paul's or Ben's so that the unimportant > characters between the whitespace get some braintime. So you mean I just put both copyright statements there? That's a nice idea! Alex