From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [PATCH] kvm tools: Use correct size for VESA memory BAR Date: Wed, 10 Aug 2011 09:13:35 +0300 Message-ID: <4E42218F.4050705@kernel.org> References: <1312903262-8212-1-git-send-email-levinsasha928@gmail.com> <20110809153912.GB7867@elte.hu> <4E416449.5020205@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Ingo Molnar , Sasha Levin , asias.hejun@gmail.com, prasadjoshi124@gmail.com, gorcunov@gmail.com, kvm@vger.kernel.org, evensky@dancer.ca.sandia.gov To: Avi Kivity Return-path: Received: from mail-wy0-f174.google.com ([74.125.82.174]:40745 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752632Ab1HJGNk (ORCPT ); Wed, 10 Aug 2011 02:13:40 -0400 Received: by wyg24 with SMTP id 24so472120wyg.19 for ; Tue, 09 Aug 2011 23:13:39 -0700 (PDT) In-Reply-To: <4E416449.5020205@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 8/9/11 7:46 PM, Avi Kivity wrote: > On 08/09/2011 06:39 PM, Ingo Molnar wrote: >> * Sasha Levin wrote: >> >> > This patch makes BAR 1 16k, instead of BAR0 - which is the PIO bar. >> > >> >> This changelog is missing some key information: >> >> - how did you find the bug (by chance via code review or did you see >> some actual badness?) >> >> - what practical effect (if any) did you see from this patch? >> >> - what practical effect (if any) do you expect others to see from >> this patch? >> >> I suspect this patch is only for completeness/correctness but has no >> practical effect - but that's a guess. >> > > My guess would be that seabios tried to lay out the BARs and had > trouble fitting a 16k pio bar in the small PCI pio region. Sasha? IIRC this fixed some issue with David's out-of-tree PCI driver?