From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 18/24] versatile_pci: convert to memory API
Date: Thu, 11 Aug 2011 19:26:20 +0300
Message-ID: <4E4402AC.3080505@redhat.com>
References: <1312823229-12822-1-git-send-email-avi@redhat.com> <1312823229-12822-19-git-send-email-avi@redhat.com> <CAFEAcA-v2ALCw52Szh9SUB+-n072t0+zKeO3nF_wxB5_TFjryQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
To: Peter Maydell <peter.maydell@linaro.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:7337 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750741Ab1HKSAt (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 11 Aug 2011 14:00:49 -0400
In-Reply-To: <CAFEAcA-v2ALCw52Szh9SUB+-n072t0+zKeO3nF_wxB5_TFjryQ@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 08/11/2011 07:20 PM, Peter Maydell wrote:
> On 8 August 2011 18:07, Avi Kivity<avi@redhat.com>  wrote:
> >  -static uint32_t pci_vpb_config_readb (void *opaque, target_phys_addr_t addr)
> >  +static uint64_t pci_vpb_config_read(void *opaque, target_phys_addr_t addr,
> >  +                                    unsigned size)
> >    {
> >       uint32_t val;
> >  -    val = pci_data_read(opaque, vpb_pci_config_addr (addr), 1);
> >  -    return val;
> >  +    val = pci_data_read(opaque, vpb_pci_config_addr(addr), size);
> >  +    return size;
> >    }
>
> This should be 'return val', not 'return size', I think...

Wow, how did that happen?

> (otherwise PCI is broken on versatilepb; tested with your memory-region
> branch rather than with this particular patch.)
>

Updated patch to follow, thanks for the report.

-- 
error compiling committee.c: too many arguments to function