From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [RFC PATCH v3 1/4] separate thread for VM migration Date: Fri, 12 Aug 2011 08:40:57 +0200 Message-ID: <4E44CAF9.1080802@redhat.com> References: <6ac256e1f481ea28678bae846a13714302f258db.1313076455.git.udeshpan@redhat.com> <4E4400EE.1030905@redhat.com> <4E441302.5090102@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, quintela@redhat.com, mtosatti@redhat.com To: Umesh Deshpande Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:58703 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750930Ab1HLGlC (ORCPT ); Fri, 12 Aug 2011 02:41:02 -0400 Received: by qwk3 with SMTP id 3so1414901qwk.19 for ; Thu, 11 Aug 2011 23:41:02 -0700 (PDT) In-Reply-To: <4E441302.5090102@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/11/2011 07:36 PM, Umesh Deshpande wrote: >> > Now, migrate_fd_cleanup, buffured_close is just executed by the > migration thread. > I am not letting iothread call any migration cancellation related > functions. In stead it just submits the request and waits for the > migration thread to terminate itself in the next iteration. > The reason is to avoid the call to qemu_fflush, > qemu_savevm_state_cancel (to carry out migrate_cancel) from iothread > while migration thread is transferring data without holding the locks. Got it now, thanks for explaining. Paolo