From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [PATCH] kvm tools: Add 'kvm memstat' command Date: Mon, 15 Aug 2011 15:06:34 +0300 Message-ID: <4E490BCA.3050003@kernel.org> References: <1313409222-3910-1-git-send-email-levinsasha928@gmail.com> <4E490964.5060509@kernel.org> <1313409745.27520.9.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mingo@elte.hu, asias.hejun@gmail.com, prasadjoshi124@gmail.com, gorcunov@gmail.com, kvm@vger.kernel.org To: Sasha Levin Return-path: Received: from mail-ww0-f44.google.com ([74.125.82.44]:43255 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751900Ab1HOMGi (ORCPT ); Mon, 15 Aug 2011 08:06:38 -0400 Received: by wwf5 with SMTP id 5so4781992wwf.1 for ; Mon, 15 Aug 2011 05:06:37 -0700 (PDT) In-Reply-To: <1313409745.27520.9.camel@lappy> Sender: kvm-owner@vger.kernel.org List-ID: On 8/15/11 3:02 PM, Sasha Levin wrote: > On Mon, 2011-08-15 at 14:56 +0300, Pekka Enberg wrote: >> On 8/15/11 2:53 PM, Sasha Levin wrote: >>> This patch adds 'kvm memstat' command that allows retrieving memory statistics out of >>> a running guest using the virtio-balloon stats vq interface. >>> >>> Signed-off-by: Sasha Levin >> Shouldn't we just call this "kvm stat"? We can print out all statistics >> by default and >> add command line options like "--mem" to display individual stats? > Do we have any other statistics to print out at the moment? Not right now but IIRC Asias talked about networking statistics. The 'kvm memstat' feels too specific to justify a separate builtin as opposed to an command line option in a 'kvm stat' command. Pekka