Re: [PATCH] kvm tools: Add 'kvm memstat' command

[Asias He <asias.hejun@gmail.com>]

On 08/15/2011 08:06 PM, Pekka Enberg wrote:
> On 8/15/11 3:02 PM, Sasha Levin wrote:
>> On Mon, 2011-08-15 at 14:56 +0300, Pekka Enberg wrote:
>>> On 8/15/11 2:53 PM, Sasha Levin wrote:
>>>> This patch adds 'kvm memstat' command that allows retrieving memory
>>>> statistics out of
>>>> a running guest using the virtio-balloon stats vq interface.
>>>>
>>>> Signed-off-by: Sasha Levin<levinsasha928@gmail.com>
>>> Shouldn't we just call this "kvm stat"? We can print out all statistics
>>> by default and
>>> add command line options like "--mem" to display individual stats?
>> Do we have any other statistics to print out at the moment?
> 
> Not right now but IIRC Asias talked about networking statistics. The
> 'kvm memstat' feels too specific to justify a separate builtin as
> opposed to an command line option in a 'kvm stat' command.

Yes. the command I am proposing is 'kvm info'. We can have a lot of
thing in 'kvm info', like register info, network info ,disk info. mem
info. Actually, Pekka suggested to have kvm info for all the infos and
if we are getting too much, we can split kvm info into sub command, like
kvm info mem, kvm info reg.

-- 
Best Regards,
Asias He