From mboxrd@z Thu Jan 1 00:00:00 1970 From: Asias He Subject: Re: [PATCH] kvm tools: Add 'kvm memstat' command Date: Tue, 16 Aug 2011 13:01:34 +0800 Message-ID: <4E49F9AE.9070401@gmail.com> References: <1313409222-3910-1-git-send-email-levinsasha928@gmail.com> <4E490964.5060509@kernel.org> <1313409745.27520.9.camel@lappy> <4E490BCA.3050003@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Sasha Levin , mingo@elte.hu, prasadjoshi124@gmail.com, gorcunov@gmail.com, kvm@vger.kernel.org To: Pekka Enberg Return-path: Received: from mail-yx0-f174.google.com ([209.85.213.174]:48849 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092Ab1HPFBv (ORCPT ); Tue, 16 Aug 2011 01:01:51 -0400 Received: by yxj19 with SMTP id 19so3550914yxj.19 for ; Mon, 15 Aug 2011 22:01:50 -0700 (PDT) In-Reply-To: <4E490BCA.3050003@kernel.org> Sender: kvm-owner@vger.kernel.org List-ID: On 08/15/2011 08:06 PM, Pekka Enberg wrote: > On 8/15/11 3:02 PM, Sasha Levin wrote: >> On Mon, 2011-08-15 at 14:56 +0300, Pekka Enberg wrote: >>> On 8/15/11 2:53 PM, Sasha Levin wrote: >>>> This patch adds 'kvm memstat' command that allows retrieving memory >>>> statistics out of >>>> a running guest using the virtio-balloon stats vq interface. >>>> >>>> Signed-off-by: Sasha Levin >>> Shouldn't we just call this "kvm stat"? We can print out all statistics >>> by default and >>> add command line options like "--mem" to display individual stats? >> Do we have any other statistics to print out at the moment? > > Not right now but IIRC Asias talked about networking statistics. The > 'kvm memstat' feels too specific to justify a separate builtin as > opposed to an command line option in a 'kvm stat' command. Yes. the command I am proposing is 'kvm info'. We can have a lot of thing in 'kvm info', like register info, network info ,disk info. mem info. Actually, Pekka suggested to have kvm info for all the infos and if we are getting too much, we can split kvm info into sub command, like kvm info mem, kvm info reg. -- Best Regards, Asias He