From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] virtio-blk: Add stats VQ to collect information about devices Date: Wed, 17 Aug 2011 16:00:42 -0700 Message-ID: <4E4C481A.5080205@redhat.com> References: <1313524071-27250-1-git-send-email-levinsasha928@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, Rusty Russell , "Michael S. Tsirkin" , virtualization@lists.linux-foundation.org, kvm@vger.kernel.org To: Sasha Levin Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50224 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753184Ab1HQXAx (ORCPT ); Wed, 17 Aug 2011 19:00:53 -0400 In-Reply-To: <1313524071-27250-1-git-send-email-levinsasha928@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/16/2011 12:47 PM, Sasha Levin wrote: > This patch adds support for an optional stats vq that works similary to the > stats vq provided by virtio-balloon. > > The purpose of this change is to allow collection of statistics about working > virtio-blk devices to easily analyze performance without having to tap into > the guest. > > Why can't you get the same info from the host? i.e. read sectors? Patches to virtio drivers should be preceded by specification updates so that guest driver authors and alternative userspace developers have a solid reference. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.