From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] virtio-blk: Add stats VQ to collect information about devices Date: Thu, 18 Aug 2011 11:30:47 -0700 Message-ID: <4E4D5A57.6070600@redhat.com> References: <1313524071-27250-1-git-send-email-levinsasha928@gmail.com> <4E4C481A.5080205@redhat.com> <1313642283.22532.4.camel@lappy> <4E4D2B6D.1040908@redhat.com> <1313684984.30799.20.camel@lappy> <4E4D4DAC.8080304@redhat.com> <1313690353.30799.22.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, Rusty Russell , "Michael S. Tsirkin" , virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, Pekka Enberg , Ingo Molnar To: Sasha Levin Return-path: In-Reply-To: <1313690353.30799.22.camel@lappy> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 08/18/2011 10:59 AM, Sasha Levin wrote: > > > > This is something that can be used by very few people, but everyone has > > to carry it. It's more efficient to add statistics support to your > > automation framework (involving the guest). > > > > That was just one example of many possibilities. However, if you feel > this can't be used within monitoring or management platforms anyhow then > I'm ok with dropping it. > It really depends on the possibilities. Adding features is fine, but we need to know they'll be useful to many people. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.