From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] pcnet-pci: fix wrong opaque given to I/O accessors
Date: Wed, 24 Aug 2011 12:22:10 +0300
Message-ID: <4E54C2C2.3030603@redhat.com>
References: <1314021534-3212-1-git-send-email-avi@redhat.com> <alpine.LFD.2.02.1108221603050.24813@bbs.intern>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org,
	kvm@vger.kernel.org
To: Gerhard Wiesinger <lists@wiesinger.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:9415 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750888Ab1HXJWO (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 24 Aug 2011 05:22:14 -0400
In-Reply-To: <alpine.LFD.2.02.1108221603050.24813@bbs.intern>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 08/22/2011 05:16 PM, Gerhard Wiesinger wrote:
> Hello Avi,
>
> Thnx, fixed: OK, maybe some credits :-)
>
> Acked-by: Gerhard Wiesinger <lists@wiesinger.com>
>
> This pattern is still present at (maybe some further problems!!!) and 
> I guess it has to be fixed, too:
>
> grep -ir 'ops, s, "' .
> ./hw/rtl8139.c:    memory_region_init_io(&s->bar_io, &rtl8139_io_ops, 
> s, "rtl8139", 0x100);
> ./hw/rtl8139.c:    memory_region_init_io(&s->bar_mem, 
> &rtl8139_mmio_ops, s, "rtl8139", 0x100);

Usually, when you have

   memory_region_init_io(&s->something, ..., s, ...)

it means everything is fine.  Lance/pcnet is special in this regard.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.