public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: penberg@kernel.org, kvm@vger.kernel.org, mingo@elte.hu,
	asias.hejun@gmail.com, gorcunov@gmail.com
Subject: Re: [PATCH] kvm tools: Improve init within a custom filesystem
Date: Wed, 24 Aug 2011 20:30:05 +0300	[thread overview]
Message-ID: <4E55351D.9020805@redhat.com> (raw)
In-Reply-To: <1314202772-16252-1-git-send-email-levinsasha928@gmail.com>

On 08/24/2011 07:19 PM, Sasha Levin wrote:
> This patch adds the following improvements:
>
>   * Automatically start dhcpcd. Since we provide usermode netowrking
> we should make it fully transparent to the user.

On my hosts, I have dhclient instead of dhcpd.

>
> +	puts("Running dhcpcd...");
> +
> +	system("dhcpcd -z eth* -A");
> +
>   	puts("Starting '/bin/sh'...");
>

Better not  depend on interface names, instead get the interface names 
from the kernel.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


  reply	other threads:[~2011-08-24 17:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-24 16:19 [PATCH] kvm tools: Improve init within a custom filesystem Sasha Levin
2011-08-24 17:30 ` Avi Kivity [this message]
2011-08-24 17:41   ` Sasha Levin
2011-08-24 18:17     ` Pekka Enberg
2011-08-24 18:51     ` Avi Kivity
2011-08-24 18:59       ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E55351D.9020805@redhat.com \
    --to=avi@redhat.com \
    --cc=asias.hejun@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=mingo@elte.hu \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox