From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm tools: Improve init within a custom filesystem Date: Wed, 24 Aug 2011 21:51:10 +0300 Message-ID: <4E55481E.6040000@redhat.com> References: <1314202772-16252-1-git-send-email-levinsasha928@gmail.com> <4E55351D.9020805@redhat.com> <1314207675.3459.9.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: penberg@kernel.org, kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com, gorcunov@gmail.com To: Sasha Levin Return-path: Received: from mx1.redhat.com ([209.132.183.28]:31581 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389Ab1HXSv2 (ORCPT ); Wed, 24 Aug 2011 14:51:28 -0400 In-Reply-To: <1314207675.3459.9.camel@lappy> Sender: kvm-owner@vger.kernel.org List-ID: On 08/24/2011 08:41 PM, Sasha Levin wrote: > On Wed, 2011-08-24 at 20:30 +0300, Avi Kivity wrote: > > On 08/24/2011 07:19 PM, Sasha Levin wrote: > > > This patch adds the following improvements: > > > > > > * Automatically start dhcpcd. Since we provide usermode netowrking > > > we should make it fully transparent to the user. > > > > On my hosts, I have dhclient instead of dhcpd. > > > > I was wondering if we should bring our own tiny dhcp client instead of > assuming the host has one. > > Would it be better than assuming the host has it and then trying to > figure out which one? > You don't really need a dhcp client, since you already have a communication channel - the kernel command line. Read the IP address and other info from there, and poke it into the interface. There is also the ip= kernel parameter, but I don't know if it works with a modular network driver. I suggest something like "kvmtool.nic.$macaddr=$ip/$netmask kvmtool.defaultroute=$gateway" - this is interface name agnostic. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.