From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm tools: adds a PCI device that exports a host shared segment as a PCI BAR in the guest Date: Thu, 25 Aug 2011 14:30:38 +0300 Message-ID: <4E56325E.4010807@redhat.com> References: <20110824222510.GC14835@dancer.ca.sandia.gov> <232C9ABA-F703-4AE5-83BC-774C715D4D8F@suse.de> <20110825044913.GA24996@dancer.ca.sandia.gov> <1314248794.32391.60.camel@jaguar> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Stefan Hajnoczi , David Evensky , Alexander Graf , David Evensky , Sasha Levin , kvm@vger.kernel.org, Ingo Molnar To: Pekka Enberg Return-path: Received: from mx1.redhat.com ([209.132.183.28]:21125 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752365Ab1HYLbN (ORCPT ); Thu, 25 Aug 2011 07:31:13 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 08/25/2011 02:15 PM, Pekka Enberg wrote: > On Thu, Aug 25, 2011 at 1:59 PM, Stefan Hajnoczi wrote: > > Introducing yet another non-standard and non-Linux interface doesn't > > help though. If there is no significant improvement over ivshmem then > > it makes sense to let ivshmem gain critical mass and more users > > instead of fragmenting the space. > > Look, I'm not going to require QEMU compatibility from tools/kvm > contributors. If you guys really feel that strongly about the > interface, then either > > - Get Rusty's "virtio spec pixie pee" for ivshmem It's not a virtio device (doesn't do dma). It does have a spec in qemu.git/docs/specs. > - Get the Linux driver merged to linux-next ivshmem uses uio, so it doesn't need an in-kernel driver, IIRC. Map your BAR from sysfs and go. > - Help out David and Sasha to change interface > > But don't ask me to block clean code from inclusion to tools/kvm > because it doesn't have a QEMU-capable interface. A lot of thought has gone into the design and implementation of ivshmem. But don't let that stop you from merging clean code. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.