Re: [PATCH 1/5] Support for vm_stop from the migration thread

Marcelo Tosatti
2011-08-29T18:50:51Z

On Sat, Aug 27, 2011 at 02:09:44PM -0400, Umesh Deshpande wrote:
> Currently, when any thread other than iothread calls vm_stop, it is scheduled to
> be executed later by the iothread. This patch allows the execution of vm_stop
> from threads other than iothread. This is especially helpful when the migration is
> moved into a separate thread.
>
> Signed-off-by: Umesh Deshpande <udeshpan@redhat.com>
> ---
> cpus.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/cpus.c b/cpus.c
> index de70e02..f35f683 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -122,8 +122,8 @@ static void do_vm_stop(int reason)
> {
> if (vm_running) {
> cpu_disable_ticks();
> - vm_running = 0;
> pause_all_vcpus();
> + vm_running = 0;
> vm_state_notify(0, reason);
> qemu_aio_flush();
> bdrv_flush_all();

Why this change?