From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH resend] KVM: Document KVM_IRQFD
Date: Mon, 29 Aug 2011 15:50:19 +0300
Message-ID: <4E5B8B0B.3030900@redhat.com>
References: <1314621244-4360-1-git-send-email-levinsasha928@gmail.com>  <4E5B87FE.7030300@redhat.com> <1314621797.29761.19.camel@sasha>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
To: Sasha Levin <levinsasha928@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:5855 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751037Ab1H2MuX (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 29 Aug 2011 08:50:23 -0400
In-Reply-To: <1314621797.29761.19.camel@sasha>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 08/29/2011 03:43 PM, Sasha Levin wrote:
> On Mon, 2011-08-29 at 15:37 +0300, Avi Kivity wrote:
> >  On 08/29/2011 03:34 PM, Sasha Levin wrote:
> >  >  Cc: Avi Kivity<avi@redhat.com>
> >  >  Cc: Marcelo Tosatti<mtosatti@redhat.com>
> >  >  Signed-off-by: Sasha Levin<levinsasha928@gmail.com>
> >
> >  Thanks, applied.
> >
> >  >  +Returns: 0 on success, !0 on error
> >  >  +
> >
> >  -1 (I fixed this).
> >
>
> Why -1? It could be anything<  0, no?
>

No.  ioctl()s (and most system calls) return -1 on error and set errno.

-- 
error compiling committee.c: too many arguments to function